G1: integrate wire-correct IEC 61850 control execution - #221
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
G1 / G1.1 Control Correctness — ARSAS integration
Stacked on frozen physical field baseline PR #220 (
c5cd6e537a31967e55aeba77da7e02f028770976). Scope is control-only. Reporting, dynamic RCB policy, polling, reconnect, quality policy, and Event Log behavior are unchanged.Exact engine
Pins ARIEC PR #90 final G1.1 head:
a18e550d07f7bbe4ff7753c180b02615075f6292What the physical test proved
The original
expected 254 bits, received 2defect is gone. The real SIPROTEC now receives SBOw, but rejects it before Operate. Physical responseA5 03 80 01 03is MMS DataAccessError 3 =object-access-denied. Independent LastApplError evidence wasControlError=operator-test,AddCause=not-supported; the relay did not reportblocked-by-interlockingorblocked-by-synchrocheckin that run.G1.1 app corrections
object-access-denied (3)instead of only1 failure(s);IED REJECTED SBOw;Operate NOT sent/Operate was NOT sent because SBOw selection failed;CONTROL_REJECTED_BY_IEDwith stage, exact reason, ControlError, AddCause, OperateSent and origin;MMS command submittedwording is removed; local dispatch says wire send is not assumed until native evidence returns;Maintenance(7)toStationControl(2). No alternate-origin retry is added;Final candidate / automated gate
ARSAS head:
2c8de5b28667af623c8e5e0c3dfeeb7d723d7290All green on exact G1.1 engine pin:
.NET CI#369: success.Physical acceptance
Keep draft/unmerged. Next test should issue one safe SBO Enhanced command. Expected request origin is
StationControl/ARSASand wireorCat=2. If it succeeds, continue throughSBOw -> Operate -> CommandTermination -> process feedback. If it still fails, the UI/diagnostic must show the exact IED rejection (object-access-denied, interlocking, synchrocheck, no-access-authority, etc.) without guessing or automatic retry.